Inline common access control checks into unchecked helpers - #745
Merged
mijinummi merged 1 commit intoJul 29, 2026
Merged
Conversation
Refactor modifier logic into an internal _checkOwner() view function so that each guarded function reuses a single check routine instead of duplicating the same bytecode at every entry point. Closes MDTechLabs#739
|
@snowrugar-beep Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored access control modifiers to invoke a non-inlined internal view function instead of repeating identical check bytecode at every function entry point, reducing deployment bytecode for multi-guarded contracts.
Changes
contracts/access/GasGuardAccess.solwith internal_checkOwner()helperonlyOwnerdelegates to_checkOwner()instead of inlining the checkCloses #739
Closes #738
Closes #737
Closes #736